Revert - Fixed the Label not sized correctly on Android (#30023) #30076
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Reverting the OnMeasure changes and 27614 test cases * Resaved the Android images * Change in unshipped file # Conflicts: # src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt
|
/azp run |
|
Azure Pipelines could not run because the pipeline triggers exclude this branch/path. |
There was a problem hiding this comment.
Pull Request Overview
Backports the revert of the Android Label sizing fix (removing the custom OnMeasure logic) to the SR8 branch, and updates tests accordingly.
- Removes the
OnMeasureoverride and helper fromMauiTextViewon Android - Updates PublicAPI to reflect removal of that override
- Cleans up old tests for issue 27614 and adds a new test and HostApp page for issue 29542
Reviewed Changes
Copilot reviewed 6 out of 25 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Core/src/PublicAPI/net-android/PublicAPI.Unshipped.txt | Marks the MauiTextView.OnMeasure override as removed in Unshipped API |
| src/Core/src/Platform/Android/MauiTextView.cs | Deletes the custom OnMeasure override and GetMaxLineWidth helper |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue29542.cs | Adds a new UI test for label sizing in a CollectionView scenario |
| src/Controls/tests/TestCases.Shared.Tests/Tests/Issues/Issue27614.cs | Removes old tests covering the previous label sizing issue |
| src/Controls/tests/TestCases.HostApp/Issues/Issue29542.cs | Adds a HostApp page to exercise the new CollectionView test |
| src/Controls/tests/TestCases.HostApp/Issues/Issue27614.cs | Removes the HostApp page for the old label sizing tests |
mattleibow
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Backport of #30023 to SR8