arm64: Add Sve2 Subtract functions #117318
Open
+1,336
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jonathandavies-arm
commented
Jul 4, 2025
jonathandavies-arm
commented
- Implements Arm64: Implement SVE2 APIs #115479
|
@dotnet/arm64-contrib @amanasifkhalid |
dotnet-policy-service
bot
added
the
community-contribution
|
Tagging subscribers to this area: @dotnet/area-system-runtime-intrinsics |
This was referenced Jul 4, 2025
Open
| CORINFO_CLASS_HANDLE argClass = NO_CLASS_HANDLE; | ||
|
|
||
| argType = JITtype2varType(strip(info.compCompHnd->getArgType(sig, arg2, &argClass))); | ||
| argType = JITtype2varType(strip(info.compCompHnd->getArgType(sig, arg1, &argClass))); |
There was a problem hiding this comment.
Since we aren't using argType anywhere, we can get rid of it and ignore the return value of this.
Suggested change
| argType = JITtype2varType(strip(info.compCompHnd->getArgType(sig, arg1, &argClass))); | |
| JITtype2varType(strip(info.compCompHnd->getArgType(sig, arg1, &argClass))); |
| /// SSUBLBT Zresult.D, Zop1.S, Zop2.S | ||
| /// </summary> | ||
| public static Vector<long> SubtractWideningEvenOdd(Vector<int> left, Vector<int> right) { throw new PlatformNotSupportedException(); } | ||
|
|
There was a problem hiding this comment.
CI says there's some trailing whitespace here that's tripping up the libraries build runs. Your editor might be able to remove any extra whitespace in these files for you (ex in VS Code: ctrl+shift+P -> "Trim Trailing Whitespace")
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.