Skip to content

GHE Server support #2

Open
Open
@davegaeddert

Description

@davegaeddert

Everything so far should work for self-hosted GHE/PullApprove, except for the domain restriction:

"https://github.com/*"

Matching all domains/pages is the easiest option, but seems pretty aggressive. Listing specific customer domains is not a good option either. I don't think a pattern match like https://*.github.* is possible.

There is also the question of whether self-hosted enterprise customers actually want an extension that is updated automatically, which is not how the self-hosted product works in the first place.

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestquestionFurther information is requested

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions