Skip to content

Safari extension #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Safari extension #4

wants to merge 2 commits into from

Conversation

davegaeddert
Copy link
Member

Everything seems to work fine, but would need to submit to Apple for this to be available.

Other notes:

  • 512px and 1024px app icons?
  • automatically increment build version?
  • release process
    • update release script to keep version in sync
    PullApprove/PullApprove.xcodeproj/project.pbxproj
497:				MARKETING_VERSION = 0.1.0;
520:				MARKETING_VERSION = 0.1.0;

@davegaeddert davegaeddert added the enhancement New feature or request label Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@davegaeddert