Skip to content

Add test for hasDayWithoutBirds method #2956

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rabestro
Copy link
Member

@rabestro rabestro commented Jun 13, 2025

pull request

  • Added a test to validate the behavior of hasDayWithoutBirds when the last day has zero visits.
  • Updated the lastWeek field to be final and align with best practices.

https://forum.exercism.org/t/bird-watcher-in-java-should-we-add-a-test-case/17933


Reviewer Resources:

Track Policies

Added a test to validate the behavior of `hasDayWithoutBirds` when the last day has zero visits. Updated the `lastWeek` field to be final and align with best practices.
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Contributor

@jagdish-15 jagdish-15 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kahgoh The forum topic doesn’t appear to have a clear resolution. What do you think, should this be merged with the [no important files changed] label, or not?

@rabestro Would love to hear your thoughts on this as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants