Rust: add Cargo.lock files to all tests with cargo check
#19772
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates .gitignore files to stop excluding Cargo.lock in test directories, ensuring Cargo.lock files can be committed alongside tests to stabilize transitive dependency versions.
- Removed the exception that ignored
Cargo.lockinextractor-tests/crate_graph - Stopped ignoring
Cargo.lockat therust/ql/testlevel
Reviewed Changes
Copilot reviewed 41 out of 41 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| rust/ql/test/extractor-tests/crate_graph/.gitignore | Removed !/Cargo.lock exception to allow locking |
| rust/ql/test/.gitignore | Removed Cargo.lock ignore entry to include lockfile |
hvitved
approved these changes
Jun 16, 2025
|
I think this may have fixed an issue I was having running the CWE-770 test locally. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should avoid test expectations differences when transitive dependencies get updated.