C++: Generate SEH edges for pointer dereference loads/stores in __try blocks
#19775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jketema
commented
Jun 16, 2025
MathiasVP
reviewed
Jun 16, 2025
| or | ||
| expr instanceof PointerDereferenceExpr and | ||
| kind instanceof SehExceptionEdge and | ||
| exists(MicrosoftTryStmt tryStmt | tryStmt.getStmt() = expr.getEnclosingStmt().getParent*()) and |
There was a problem hiding this comment.
We should probably lift this out to a predicate at this point so that we don't accidentally write the wrong predicate you fixed in 1b2813d
There was a problem hiding this comment.
I've unified the two in TranslatedExpr.qll.
|
DCA is happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently limited to cases where a pointer deference is involved, and not doing anything for loads/stores that are part of specific initializations (like in adafc7d).