-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Blog post on Knative Functions with Llama stack for AI inference #6287
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for knative ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify project configuration. |
fc233f0
to
c2c201e
Compare
Signed-off-by: Matthias Wessendorf <mwessend@redhat.com>
c2c201e
to
e71949b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like the blog! I left a bit of feedback about the level of headers since it felt like a few of them could be a bit bigger when reading the rendered blog. Also a few nits/typo feedback
|
||
#### Accessing the Llama Stack Server | ||
|
||
Inside the `init` we get access to the URL of the _Llama Stack_ and fetch the available models: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What is the init
here? Could you provide a bit more context? Maybe something along the lines of "inside the __init__
method of the Function
class..."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Co-authored-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
Co-authored-by: Calum Murray <cmurray@redhat.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: Cali0707, matzew The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
"Fixes #issue-number" or "Add description of the problem this PR solves"
Proposed Changes