[UI automation] workspaces ui automation #39812
Conversation
…osoft/powertoys into dev/nxu/ImproveUIAutomation
1. SetWindowSize 2. Auto-close 3. Better window search logic
Rebase from origin/dev/nxu/ImproveUIAutomation
…t/PowerToys into dev/vanzue/workspace-automation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
src/modules/Workspaces/WorkspacesEditorUITest/WorkspacesEditingPageTests.cs
Fixed
Show fixed
Hide fixed
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
src/modules/Workspaces/WorkspacesEditorUITest/WorkspacesEditingPageTests.cs
Fixed
Show fixed
Hide fixed
This comment has been minimized.
This comment has been minimized.
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces UI automation tests and related automation base classes for the Workspaces module. Key changes include adding checklist documentation for UI automation, several new and updated test methods for workspaces functionality, and improvements to UI elements and helper classes to support test automation.
Reviewed Changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| ui-automation-workspace.md | Added checklist for manual UI automation test steps. |
| WorkspacesUiAutomationBase.cs | Introduced helper methods for workspace automation and improved workspace management functions. |
| WorkspacesSnapshotTests.cs, WorkspacesSettingsTests.cs, WorkspacesLauncherTest.cs, WorkspacesEditorTests.cs | Added and updated test cases covering workspace capture, launch, sorting, and settings interactions. |
| MainPage.xaml(.cs) and WorkspacesEditorPage.xaml | Updated UI elements (e.g., AutomationProperties, Popup handling) for better testability. |
| MainViewModel.cs, KeyboardHelper.cs, WindowHelper.cs, PowerToys.sln | Minor enhancements to process startup, key translation, helper accessibility, and solution configuration. |
| // DO NOT USE UNTIL FRAMEWORK AVAILABLE, CAN'T FIND BUTTON FOR SECOND LOOP | ||
| protected void ClearWorkspaces() | ||
| { | ||
| while (true) |
There was a problem hiding this comment.
The ClearWorkspaces method uses an infinite loop with a try-catch block to exit, which may lead to endless iterations in unexpected scenarios. Consider adding a maximum retry counter or timeout mechanism to prevent potential infinite looping.
| while (true) | |
| const int MAX_RETRIES = 10; | |
| int retryCount = 0; | |
| while (retryCount < MAX_RETRIES) |
Copilot uses AI. Check for mistakes.
src/modules/Workspaces/WorkspacesEditorUITest/WorkspacesEditingPageTests.cs
Fixed
Show fixed
Hide fixed
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Summary of the Pull Request
PR Checklist
Detailed Description of the Pull Request / Additional comments
Validation Steps Performed