fix cryomagnetics4g driver bug. #7114
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jenshnielsen
reviewed
May 5, 2025
| @@ -0,0 +1,3 @@ | |||
| 1. Fixed the problem that there is no specific initialization variable in self._RETRY_WRITE_ASK. | |||
| 2. Fix the instrument status recognition problem in self.set_field. | |||
| 3. Fixed the ramping state recognition issue in wait_while_ramping. | |||
There was a problem hiding this comment.
Could you reword this so it's clear which driver this refers to
There was a problem hiding this comment.
Sorry about that! I've updated the code in a new commit following your suggestion.
jenshnielsen
reviewed
May 5, 2025
| if not exit_state.holding: | ||
| msg = "_set_field({}) failed with state: {}" | ||
| raise Cryomagnetics4GException(msg.format(field_setpoint, exit_state)) | ||
| if not exit_state.standby: |
There was a problem hiding this comment.
Suggested change
| if not exit_state.standby: | |
| if not exit_state.standby and not exit_state.holding: |
Writing this on one line will make the logic clearer.
There was a problem hiding this comment.
yes! I've updated the code accordingly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I am trying to fix several bugs in cryomagnetics4g:
self._RETRY_WRITE_ASKto determine whether to re-communicate, but I did not see the definition ofself._RETRY_WRITE_ASKin the code, so I addedset_fieldfunction is executed, it will determine whether the magnetic field setting is normal by judging whether the final state is the Holding state. However, he forgot one situation——when the magnetic field is set to 0T, the magnet power supply will enter the Standby state instead of Holding, so I added a judgment to fix this problem.status_byte = int(self.ask("*STB?")), when the magnet state is not ramping, it means that the excitation is complete. However, there is a problem with this magnet power supply——even if the magnetic field has been added to the specified value, the state is still ramping and will not change! So I changed to ask the current magnetic field valueself._get_field()to determine whether the excitation is complete