Skip to content

[High] Patch libsoup for CVE-2025-32907 #14000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

kevin-b-lockwood
Copy link
Contributor

@kevin-b-lockwood kevin-b-lockwood commented Jun 13, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./SPECS/LICENSES-AND-NOTICES/data/licenses.json, ./SPECS/LICENSES-AND-NOTICES/LICENSES-MAP.md, ./SPECS/LICENSES-AND-NOTICES/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • If you are adding/removing a .spec file that has multiple-versions supported, please add @microsoft/cbl-mariner-multi-package-reviewers team as reviewer (Eg. golang has 2 versions 1.18, 1.21+)
  • Ready to merge

Summary

Adds a patch for libsoup to fix CVE-2025-32907

Change Log
  • Also fix bogus date from previous change

Patch applies cleanly
Upstream Patch References:

  1. https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/452/diffs?commit_id=9bb92f7a685e31e10e9e8221d0342280432ce836
  2. https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/452/diffs?commit_id=eeace39ec686094ff6a05a43e5fce06e9c37f376
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology
  • Local build

@kevin-b-lockwood kevin-b-lockwood requested a review from a team as a code owner June 13, 2025 17:17
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging fasttrack/2.0 PRs Destined for Azure Linux 2.0 labels Jun 13, 2025
@Kanishk-Bansal
Copy link
Contributor

/azurepipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@Sumynwa
Copy link
Contributor

Sumynwa commented Jun 16, 2025

No difference wrt to patch changes in https://gitlab.gnome.org/GNOME/libsoup/-/merge_requests/452/diffs.
Looking at logs, the patch is applied when building package.

@Sumynwa
Copy link
Contributor

Sumynwa commented Jun 16, 2025

@kevin-b-lockwood kevin-b-lockwood marked this pull request as draft June 16, 2025 16:52
@kevin-b-lockwood kevin-b-lockwood force-pushed the kevin-b-lockwood/libsoup-2.0-CVE branch from e27e14e to babfe37 Compare June 16, 2025 22:37
Also fix bogus date from previous change
@kevin-b-lockwood kevin-b-lockwood force-pushed the kevin-b-lockwood/libsoup-2.0-CVE branch from babfe37 to 9dbd23f Compare June 16, 2025 22:41
@kevin-b-lockwood kevin-b-lockwood marked this pull request as ready for review June 17, 2025 15:52
@sameluch
Copy link
Contributor

/azurepipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@sameluch sameluch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ostree ptest normally skipped, is an expected failure on both arches

@jslobodzian jslobodzian merged commit 111dbba into microsoft:fasttrack/2.0 Jun 17, 2025
19 of 22 checks passed
CBL-Mariner-Bot pushed a commit that referenced this pull request Jun 17, 2025
@CBL-Mariner-Bot
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fasttrack/2.0 PRs Destined for Azure Linux 2.0 Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants