-
Notifications
You must be signed in to change notification settings - Fork 580
Addressed multiple grub2 CVEs #14018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates the grub2 package to address multiple security vulnerabilities by applying upstream patches for various CVEs and adjusting the spec files accordingly.
- Bumps the grub2 and grub2-efi-binary-signed release numbers to match the new patch level.
- Adds or updates a series of patch files addressing CVE-2025-0684, CVE-2024-45782, CVE-2024-45778, CVE-2025-0686, CVE-2025-0678, CVE-2025-0685, CVE-2024-45779, CVE-2025-0689, CVE-2024-45780, CVE-2025-1125, CVE-2025-0690, CVE-2024-45783, CVE-2024-45776, CVE-2024-45777, CVE-2025-0677, CVE-2025-1118, CVE-2024-45775, CVE-2024-45781, CVE-2024-45774, CVE-2024-56737, CVE-2017-7526, CVE-2019-13627, and CVE-2014-3591.
Reviewed Changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
File | Description |
---|---|
SPECS/grub2/grub2.spec | Release number bump and additions to the patch list for new CVEs. |
SPECS/grub2/CVE-*.patch | Multiple patch updates addressing individual CVEs with modifications to functions and security checks. |
SPECS-SIGNED/grub2-efi-binary-signed.spec | Release number bump to maintain consistency with grub2.spec. |
Comments suppressed due to low confidence (2)
SPECS/grub2/CVE-2019-13627.patch:58
- [nitpick] Consider adding a comment to explain the rationale behind comparing 'scalar' with 'ctx->p' and choosing the respective nbits calculation to improve code clarity for future maintainers.
+ if (mpi_cmp (scalar, ctx->p) >= 0)
SPECS/grub2/CVE-2025-0690.patch:46
- Consider using a separate temporary variable instead of reusing 'i' for the arithmetic operation with grub_add to improve clarity and reduce potential hidden issues with in-place modification.
+ if (grub_add (i, 1, &i))
@microsoft/cbl-mariner-bootloader, please do let me know any specific testing I need to do for grub2 package? Will a full build do the needful? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would request that we do a full build of this specific change and then test the resulting ISO/VM image if it properly boots - preferably both in Azure & Locally.
Also, it seems our build is failing: link
Merge Checklist
All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)
*-static
subpackages, etc.) have had theirRelease
tag incremented../cgmanifest.json
,./toolkit/scripts/toolchain/cgmanifest.json
,.github/workflows/cgmanifest.json
)./LICENSES-AND-NOTICES/SPECS/data/licenses.json
,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md
,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON
)*.signatures.json
filessudo make go-tidy-all
andsudo make go-test-coverage
passSummary
Addressing Grub2 multiple CVEs
Change Log
Addressed multiple grub2 CVEs
Modified grub2 spec for the same
CVE-2025-0684
CVE-2024-45782
CVE-2024-45778
CVE-2025-0686
CVE-2025-0678
CVE-2025-0685
CVE-2024-45779
CVE-2025-0689
CVE-2024-45780
CVE-2025-1125
CVE-2025-0690
CVE-2024-45783
CVE-2024-45776
CVE-2024-45777
CVE-2025-0677
CVE-2025-1118
CVE-2024-45775
CVE-2024-45781
CVE-2024-45774
CVE-2024-56737
CVE-2017-7526
CVE-2019-13627
CVE-2014-3591
Does this affect the toolchain?
YES/NO
Associated issues
Links to CVEs
Test Methodology