Skip to content

[Medium] Patch nbdkit for CVE-2025-47711 & CVE-2025-47712 #14032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 26, 2025

Conversation

durgajagadeesh
Copy link
Contributor

@durgajagadeesh durgajagadeesh commented Jun 18, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary
Change Log
Does this affect the toolchain?

NO

Associated issues
  • #xxxx
Links to CVEs
Test Methodology

@durgajagadeesh durgajagadeesh requested a review from a team as a code owner June 18, 2025 16:59
@durgajagadeesh durgajagadeesh marked this pull request as draft June 18, 2025 17:01
@durgajagadeesh durgajagadeesh marked this pull request as ready for review June 19, 2025 03:52
@Malateshk007 Malateshk007 requested a review from mfrw June 19, 2025 05:15
Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but a small verification requested.

Date: Wed, 18 Jun 2025 14:40:17 +0000
Subject: [PATCH] Address CVE-2025-47711

Upstream patch reference: https://gitlab.com/nbdkit/nbdkit/-/commit/c3c1950867ea8d9c2108ff066ed9e78dde3cfc3f
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch Looks good w.r.t upstream ref

Date: Wed, 18 Jun 2025 16:11:18 +0000
Subject: [PATCH] Address CVE-2025-47712

Upstream patch reference: https://gitlab.com/nbdkit/nbdkit/-/commit/a486f88d1eea653ea88b0bf8804c4825dab25ec7
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Patch looks good w.r.t upstream

@@ -1193,6 +1195,10 @@ export LIBGUESTFS_TRACE=1


%changelog
* Wed Jun 18 2025 Durga Jagadeesh Palli <v-dpalli@microsoft.com> - 1.35.3-4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please once verify that the same tests are failing before and after applying the patch and that we have not introduced any new test regression.

Copy link
Contributor Author

@durgajagadeesh durgajagadeesh Jun 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mfrw ,
This is the log before i applied my patches, this also appears to be failing.
nbdkit-1.35.3-3.cm2.src.rpm.test.log

And This is the log after i applied my patches, this also appears to be failing.
nbdkit-1.35.3-4.cm2.src.rpm.test.log

Thank you!

Copy link
Member

@mfrw mfrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks

@0xba1a 0xba1a merged commit 94f44bd into microsoft:main Jun 26, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants