Skip to content

[Low] Patch libxml2 for CVE-2025-6170 #14228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

BinduSri-6522866
Copy link

@BinduSri-6522866 BinduSri-6522866 commented Jul 7, 2025

Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary

Patch libxml2 for CVE-2025-6170
Patch modified: Yes

  • result/scripts/long_command, test/scripts/long_command.script and test/scripts/long_command.xml files are not - present in source tar ball. So, patch is not applied for these files.
  • Affected code present in existing libxml2 version ( debugXML.c ) '2.10.4' and available patch version '2.14.x' ( shell.c ) file and function names are different. Hence, modified affected code in xmlShell ( xmllintShell in upstream patch) function.
  • Astrolabe patch reference link: https://gitlab.gnome.org/GNOME/libxml2/-/issues/941 navigates to https://gitlab.gnome.org/GNOME/libxml2/-/merge_requests/321/diffs
Change Log
  • new file: SPECS/libxml2/CVE-2025-6170.patch
  • modified: SPECS/libxml2/libxml2.spec
  • modified: toolkit/resources/manifests/package/pkggen_core_aarch64.txt
  • modified: toolkit/resources/manifests/package/pkggen_core_x86_64.txt
  • modified: toolkit/resources/manifests/package/toolchain_aarch64.txt
  • modified: toolkit/resources/manifests/package/toolchain_x86_64.txt
Does this affect the toolchain?

YES

Links to CVEs
Test Methodology

@BinduSri-6522866 BinduSri-6522866 requested review from a team as code owners July 7, 2025 11:15
@BinduSri-6522866 BinduSri-6522866 marked this pull request as draft July 7, 2025 11:15
@microsoft-github-policy-service microsoft-github-policy-service bot added Packaging specs-extended PR to fix SPECS-EXTENDED documentation Improvements or additions to documentation Tools Schema Changes to image configurations 3.0 PRs Destined for 3.0 labels Jul 7, 2025
@BinduSri-6522866 BinduSri-6522866 changed the base branch from 3.0 to main July 7, 2025 11:23
@microsoft-github-policy-service microsoft-github-policy-service bot added the main PR Destined for main label Jul 7, 2025
@BinduSri-6522866 BinduSri-6522866 marked this pull request as ready for review July 7, 2025 11:53
@Malateshk007 Malateshk007 requested a review from mfrw July 8, 2025 06:14
@Malateshk007 Malateshk007 removed 3.0 PRs Destined for 3.0 specs-extended PR to fix SPECS-EXTENDED documentation Improvements or additions to documentation Tools Schema Changes to image configurations labels Jul 9, 2025
@mfrw mfrw closed this Jul 10, 2025
@mfrw mfrw reopened this Jul 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
main PR Destined for main Packaging security
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants