Fix missing headers and content for conditional create. #4995
+406
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarunmathew12
added
Bug
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...alth.Fhir.Shared.Core.UnitTests/Features/Resources/ResourceHandlerTests_ConditionalCreate.cs
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Shared.Api/Controllers/FhirController.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Shared.Api/Controllers/FhirController.cs
Outdated
Show resolved
Hide resolved
src/Microsoft.Health.Fhir.Shared.Api/Controllers/FhirController.cs
Outdated
Show resolved
Hide resolved
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The change will address an issue where conditional create fails to return the content and appropriate headers when the condition provided matches a resource already existing. Also, a handling of the Prefer header in a request is added for returning the content in a requested form.
Related issues
Addresses [issue #146261].
User Story 146261: As an Api Developer I'd like Content-Location, Etag and LastModified headers returned on Conditional Create and Conditional Update requests
Testing
Tested manually and also by adding e2e test.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)