Updating the error message during conditional reference #5007
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nts to Multiple Records
…personal/v-shnarang/bug77964
…personal/v-shnarang/bug77964
v-rachitsh
added
Bug
| @@ -74,6 +74,10 @@ public async Task ResolveReferencesAsync(Resource resource, IDictionary<string, | |||
| { | |||
There was a problem hiding this comment.
This check needs to be changed to be where results equal 0 instead of not equal to 1, otherwise the new else if won't be reached.
| @@ -74,6 +74,10 @@ public async Task ResolveReferencesAsync(Resource resource, IDictionary<string, | |||
| { | |||
| throw new RequestNotValidException(string.Format(Core.Resources.InvalidConditionalReference, reference.Reference)); | |||
| } | |||
| else if (results.Count > 1) | |||
There was a problem hiding this comment.
The count needs to be the matched results, so this needs the same filter as the if statement above it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The PR updates the error message of conditional references when multiple resources are found. Instead of stating "does not resolve to a resource," the message will now indicate that the reference resolved to multiple resources.
Related issues
Addresses issue #77964.
Testing
These changes were tested on the OSS FHIR server, and we received the expected error output.
FHIR Team Checklist
Semver Change (docs)
Patch|Skip|Feature|Breaking (reason)