Skip to content

Remove constraints on Code Overflow column from xxxSearchParam tables #5025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 1, 2025

Conversation

rajithaalurims
Copy link
Contributor

@rajithaalurims rajithaalurims commented Jun 17, 2025

Description

Removed constraints on Code and Code Overflow columns from xxxSearchParam tables.

Related issues

Addresses [issue #160420].

Testing

Manually verified the scenario by testing with same data that is breaking before the change
Existing unit and E2E tests

FHIR Team Checklist

  • Update the title of the PR to be succinct and less than 65 characters
  • Add a milestone to the PR for the sprint that it is merged (i.e. add S47)
  • Tag the PR with the type of update: Bug, Build, Dependencies, Enhancement, New-Feature or Documentation
  • Tag the PR with Open source, Azure API for FHIR (CosmosDB or common code) or Azure Healthcare APIs (SQL or common code) to specify where this change is intended to be released.
  • Tag the PR with Schema Version backward compatible or Schema Version backward incompatible or Schema Version unchanged if this adds or updates Sql script which is/is not backward compatible with the code.
  • When changing or adding behavior, if your code modifies the system design or changes design assumptions, please create and include an ADR.
  • CI is green before merge Build Status
  • Review squash-merge requirements

Semver Change (docs)

Patch|Skip|Feature|Breaking (reason)

@rajithaalurims rajithaalurims requested a review from a team as a code owner June 17, 2025 20:03
@rajithaalurims rajithaalurims added Bug Bug bug bug. Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs labels Jun 17, 2025
@rajithaalurims rajithaalurims added this to the CY25Q2/2Wk06 milestone Jun 17, 2025
@SergeyGaluzo
Copy link
Contributor

We use len() in check constraints on other tables. Should we fix these too?

@SergeyGaluzo
Copy link
Contributor

With addition of delayed writes to search param tables all checks must be performed on input table variables to MergeResources stored procedure. Please add.

@paorodma-ms
Copy link
Contributor

Should we rename the PR to something more in line with the actual changes?

@rajithaalurims rajithaalurims changed the title Replacing Len function with DATALENGTH function Remove constraints on Code Overflow column from xxxSearchParam tables Jun 30, 2025
@rajithaalurims rajithaalurims merged commit edca5f4 into main Jul 1, 2025
46 of 49 checks passed
@rajithaalurims rajithaalurims deleted the personal/rajitha/fix-tokensearch-constraint branch July 1, 2025 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure Healthcare APIs Label denotes that the issue or PR is relevant to the FHIR service in the Azure Healthcare APIs Bug Bug bug bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants