Skip to content

Create Rate optimization Pricing models page (POC for future release) #1536

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

flanakin
Copy link
Collaborator

🛠️ Description

Create a simple pricing model page that breaks down pricing options to identify opportunities to save via commitment discounts. This is an early preview that is not complete. The page is hidden by default. This is only in the KQL Rate optimization report. It will be added to the storage report when finalized.

📋 Checklist

🔬 How did you test this change?

  • 🤏 Lint tests
  • 🤞 PS -WhatIf / az validate
  • 👍 Manually deployed + verified
  • 💪 Unit tests
  • 🙌 Integration tests

🙋‍♀️ Do any of the following that apply?

  • 🚨 This is a breaking change.
  • 🤏 The change is less than 20 lines of code.

📑 Did you update docs/changelog.md?

  • ✅ Updated changelog (required for dev PRs)
  • ➡️ Will add log in a future PR (feature branch PRs only)
  • ❎ Log not needed (small/internal change)

📖 Did you update documentation?

  • ✅ Public docs in docs (required for dev)
  • ✅ Internal dev docs in src (required for dev)
  • ➡️ Will add docs in a future PR (feature branch PRs only)
  • ❎ Docs not needed (small/internal change)

@flanakin flanakin requested a review from arthurclares as a code owner April 25, 2025 09:44
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs: Review 👀 PR that is ready to be reviewed label Apr 25, 2025
@flanakin flanakin added this to the 2025-04 - April milestone Apr 28, 2025
@flanakin flanakin added the Tool: Power BI Power BI reports label Apr 30, 2025
@@ -32,7 +32,7 @@ queryGroup 'Data Explorer'

annotation __PBI_TimeIntelligenceEnabled = 0

annotation PBIDesktopVersion = 2.141.1177.0 (25.03)+c500dc5720dc9271c2dcfef1230911a0da742ee3
annotation PBIDesktopVersion = 2.142.1027.0 (25.04)+de52df9f0bb74ad93a80d89c52d63fe6d07e0e1b
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What happens if we don't make this change? Isn't this what causes that warning message about PBI version being different?
Not a big deal, though.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suspect it is causing that message. I'm not sure if we can avoid it all the time. It depends on what's changing. I'm a bit nervous to remove it when there are big changes. I do remove it when there are small changes that don't touch change JSON object properties.

@flanakin flanakin marked this pull request as draft June 11, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Review 👀 PR that is ready to be reviewed Tool: Power BI Power BI reports
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants