refactor(apollo-forest-run): cleanup + changes necessary for future fragment watching #575
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
June 20, 2025 17:16
vladar
changed the title
added 2 commits
June 21, 2025 11:42
vladar
changed the title
pavelglac
approved these changes
Jun 23, 2025
| logUpdateStats(this.env, activeTransaction.writes, watchesToNotify); | ||
| logUpdateStats( | ||
| this.env, | ||
| activeTransaction.changelog.filter(isWrite), |
There was a problem hiding this comment.
question: do we really want to always filter? What about to just pass changelog and only if ff is enabled to filter?
There was a problem hiding this comment.
Good point. Updated in 4f8fb25
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various refactors which shouldn't have significant effect on any behavior: