`workspace.workspaceFolders` client capability missing dynamic registration support #2133

Open

microsoft/vscode-languageserver-node

Open

workspace.workspaceFolders client capability missing dynamic registration support#2133

microsoft/vscode-languageserver-node

Labels

Contributor

The protocol currently specifies that the workspace.workspaceFolders client capability is simply a boolean, but then it isn't clear how a server can tell whether an editor supports dynamic registration for the workspace/didChangeWorkspaceFolders notification.

ContributorAuthor

In fact, it isn't clear which client capability maps to the workspace/didChangeWorkspaceFolders request. Based on the VS Code implementation it seems that editors that supports workspace/workspaceFolders should also support workspace/didChangeWorkspaceFolders (?).

linked a pull request that will close this issue

Add WorkspaceFoldersClientCapabilites microsoft/vscode-languageserver-node#1627

linked a pull request that will close this issue

Add WorkspaceFoldersClientCapabilities #2134

added

Member

Yes, this was always the assumption. If a client supports workspace folder it supports change notifications. I would like to keep it that way and rather doc in the spec since changing this might break existing servers.

ContributorAuthor

Yes, this was always the assumption. If a client supports workspace folder it supports change notifications. I would like to keep it that way and rather doc in the spec since changing this might break existing servers.

Okay I understand that, but there's still no information in the client's capabilities about dynamic registration support for the workspace/didChangeWorkspaceFolders notification.

to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Assignees

No one assigned

Labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

Participants