Skip to content

Improved FIFO latency #549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 21 commits into
base: main
Choose a base branch
from
Open

Improved FIFO latency #549

wants to merge 21 commits into from

Conversation

chhwang
Copy link
Contributor

@chhwang chhwang commented Jun 13, 2025

  • Do not use cudaHostAllocWriteCombined.
  • Cache the tail value on the device.
  • Deprecate tail replica.
  • Fixed a potential race condition.

@chhwang
Copy link
Contributor Author

chhwang commented Jun 13, 2025

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

@chhwang chhwang requested a review from Binyang2014 June 16, 2025 01:19
@chhwang
Copy link
Contributor Author

chhwang commented Jun 16, 2025

/azp run mscclpp-test

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chhwang
Copy link
Contributor Author

chhwang commented Jun 17, 2025

/azp run mscclpp-test

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@chhwang chhwang requested a review from Binyang2014 June 20, 2025 02:15
@chhwang
Copy link
Contributor Author

chhwang commented Jun 20, 2025

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

trigger.snd ^= flipMask;

// Wait until the trigger is freed by the host.
POLL_MAYBE_JAILBREAK((hostLoadRelaxed(&(triggers[triggerIdx].fst)) != 0), maxSpinCount);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We access the host data for every push operation. Will it bring addtional cost?

@chhwang
Copy link
Contributor Author

chhwang commented Jun 20, 2025

/azp run

Copy link

Azure Pipelines successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants