Skip to content

Add support for JavaType.UUID #2692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Conversation

divang
Copy link
Contributor

@divang divang commented Jun 19, 2025

Description
This PR addresses the issue introduced by the previously merged and reverted PR: #2324.

The original intent was to add support for sending UUID parameters using TDSType.GUID (0x24) over the wire, aligning with the feature request in #1582.

Currently, to use this functionality, the UUID must be passed to the driver as a String with the JDBCType.GUID. Example usage:

Example:

st.setObject(index, myUUID.toString(), microsoft.sql.Types.GUID);

This PR revisits that implementation with necessary adjustments to ensure proper support and stability.

Note: This PR incorporates the community-contributed changes from PR: #2412.

@divang divang changed the title User/divang/1582 java type UUID Add support for JavaType.UUID Jun 19, 2025
Copy link

codecov bot commented Jun 19, 2025

Codecov Report

Attention: Patch coverage is 37.50000% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.85%. Comparing base (a0ea23a) to head (a728f79).
Report is 20 commits behind head on main.

Files with missing lines Patch % Lines
...rc/main/java/com/microsoft/sqlserver/jdbc/dtv.java 33.33% 3 Missing and 1 partial ⚠️
...n/java/com/microsoft/sqlserver/jdbc/DataTypes.java 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main    #2692      +/-   ##
============================================
+ Coverage     51.59%   51.85%   +0.26%     
- Complexity     3999     4032      +33     
============================================
  Files           147      147              
  Lines         33706    33810     +104     
  Branches       5631     5650      +19     
============================================
+ Hits          17391    17533     +142     
+ Misses        13866    13808      -58     
- Partials       2449     2469      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants