-
Notifications
You must be signed in to change notification settings - Fork 437
Add support for JavaType.UUID #2692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
divang
wants to merge
11
commits into
main
Choose a base branch
from
user/divang/1582_JavaTypeUUID
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UUID # Conflicts: # src/test/java/com/microsoft/sqlserver/jdbc/AlwaysEncrypted/JDBCEncryptionDecryptionTest.java
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2692 +/- ##
============================================
+ Coverage 51.59% 51.85% +0.26%
- Complexity 3999 4032 +33
============================================
Files 147 147
Lines 33706 33810 +104
Branches 5631 5650 +19
============================================
+ Hits 17391 17533 +142
+ Misses 13866 13808 -58
- Partials 2449 2469 +20 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses the issue introduced by the previously merged and reverted PR: #2324.
The original intent was to add support for sending UUID parameters using TDSType.GUID (0x24) over the wire, aligning with the feature request in #1582.
Currently, to use this functionality, the UUID must be passed to the driver as a String with the JDBCType.GUID. Example usage:
Example:
This PR revisits that implementation with necessary adjustments to ensure proper support and stability.
Note: This PR incorporates the community-contributed changes from PR: #2412.