Add test_engine connections #124
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…microsoft/power-platform-terraform-quickstarts into mawasile/coe-kit-iac-quickstart
* Review edits * Update pwsh * Adding environment variable
Grant-Archibald-MS
requested review from
mawasile,
mattdot,
leighatami,
ianjensenisme,
polatengin and
eduardodfmex
as code owners
|
@Grant-Archibald-MS Thank you for your contributions, I will take a look.! |
Signed-off-by: mawasile <50197777+mawasile@users.noreply.github.com>
mawasile
requested changes
Oct 23, 2024
| } | ||
|
|
||
|
|
||
| //TODO add comment expalining where that came from and how to update it if you need new connections referenced going into your new released solution |
There was a problem hiding this comment.
can we remove this TODO comment?
| } | ||
| } | ||
|
|
||
| //TODO: If not build from source use "pac test run" to execute the the testPlan to create required connections |
There was a problem hiding this comment.
this comment should be in readme file?
| @@ -0,0 +1,25 @@ | |||
| resource "null_resource" "build_from_source" { | |||
| #count = var.parameters.release.build_from_source && !var.parameters.release.connections_exist ? 1 : 0 | |||
There was a problem hiding this comment.
shoudn't this be uncommented?
| solution_name = "CreatorKitCore" | ||
| } | ||
|
|
||
| module "create_connections" { |
There was a problem hiding this comment.
this module executes every time, but it should execute only when connection creation mode is set to test_engine. And it does not build using dontnet in linux container
| core_components_parameters = { | ||
| admin_admine_mail_preferred_language = "en-US", | ||
| admin_admin_mail = "admin@contoso.com", | ||
| admin_app_connections_dataflow_id = "", //empty for import //what is that? |
There was a problem hiding this comment.
should we add comments explaining those parameters? Otherwise we should remove those comments completly
- Removed unused files and directories - Added variables for DLP policy creation - Updated main.tf to include DLP policy module - Updated readme.md with Linux commands
…tions Adding missing features
…coe-kit-connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of installation and automation of the CoE Kit active connections are required to enable cloud flows required for the setup and upgrade wizard.
The contribution adds a new sample terraform module that enables connections to be created using the Power Apps Portal to create interactive connections using Test Engine. The terraform module makes use of the generated connections.json file to update the solution settings used as part of solution import so that the connection references are connected to the supplied connection ids.
When imported with active connections that required Power Automate Cloud flows are enabled yb default so that the setup and upgrade wizard works as expected.
When the CoE Kit is imported without connections or with invalid connections the cloud flows will not be enabled and manual intervention is required to fix the connections and enable the required cloud flows to enable correct operation of the wizard steps.