-
Notifications
You must be signed in to change notification settings - Fork 4k
.Net: AgentKernelPluginFactory.CreateFromAgents - enable direct support for agents implicitly #11443
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joslat
wants to merge
10
commits into
microsoft:main
Choose a base branch
from
joslat:joslat-agents-as-plugins-implicit-conversion
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
.Net: AgentKernelPluginFactory.CreateFromAgents - enable direct support for agents implicitly #11443
joslat
wants to merge
10
commits into
microsoft:main
from
joslat:joslat-agents-as-plugins-implicit-conversion
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crickman
reviewed
Apr 10, 2025
dotnet/src/Agents/Core/Functions/KernelPluginFactoryExtensions.cs
Outdated
Show resolved
Hide resolved
crickman
reviewed
Apr 10, 2025
dotnet/src/Agents/Core/Functions/KernelPluginFactoryExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Agents/Core/Functions/KernelPluginFactoryExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Agents/Core/Functions/KernelPluginFactoryExtensions.cs
Outdated
Show resolved
Hide resolved
dotnet/src/Agents/Core/Functions/KernelPluginFactoryExtensions.cs
Outdated
Show resolved
Hide resolved
…//github.com/joslat/semantic-kernel into joslat-agents-as-plugins-implicit-conversion
@markwallace-microsoft all changes applied 👍 |
markwallace-microsoft
approved these changes
Apr 17, 2025
LGTM: having a unit test or a few would be helpful here. |
SergeyMenshykh
approved these changes
Apr 17, 2025
westey-m
approved these changes
Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
while in Python:
plugins=[billing_agent, refund_agent],
Scenario
Making easier and simpler to write agentic code :)
Issue: .NET Agents New Feature: When Adding an agent as a plugin it is too verbose, I want to do it like in Python! #11439
Description
Added the change as an extension method as KernelPluginFactory is in SemanticKernel.Core without any reference to Agents.Core where the method is. Unsure you would like to add a reference to it in the SemanticKernel.Core, but it would be a lot more simpler to implement.
Now, the changes have been applied here:
semantic-kernel/dotnet/samples/GettingStartedWithAgents/Step08_AgentAsKernelFunction.cs
Line 71 in 0ff97c7
So it would look instead of the above code as:
Which is a little less verbose, and more similar to the Python code.
Contribution Checklist