Skip to content

Workaround for not terminated npm process #19030

Answered by lhecker
segrey asked this question in Q&A
Discussion options

You must be logged in to vote

I suspect this only fixes your specific edge case but will then fail to work for more complex cases. If you read the PR, you'll see how fundamentally, the "early abort" that the previous code did, breaks any and all assumptions about this. It's just plain wrong.

While I would not endorse your workaround (because it's technically not "correct"), if I was you, and it fixed this issue for me, I'd go with it.

Replies: 1 comment 4 replies

Comment options

You must be logged in to vote
4 replies
@lhecker
Comment options

@segrey
Comment options

@lhecker
Comment options

Answer selected by segrey
@segrey
Comment options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Category
Q&A
Labels
None yet
2 participants