Skip to content

feat: Create tenant level connections #402

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

bartveenstra
Copy link

📥 Pull Request

❓ What are you trying to address

The current terraform provider does not support creating tenant level connections. By creating the connections resource provider, we can use terraform for setting up database mirrors at scale with support for virtual networking gateways and service principal authentication

✨ Description of new changes

Created a terraform resource and data provider called fabric_connection that enables setting up fabric connections using the different authentication methods.

☑️ PR Checklist

  • Link to the issue you are addressing is included above
  • Ensure the PR description clearly describes the feature you're adding and any known limitations

☑️ Resources / Data Sources Checklist

PRs for new/enhanced resources or data sources are expected to meet the following criteria:

bartv-bb added 12 commits April 14, 2025 07:17
…ma and models

- Added data source for connections with schema and read functionality.
- Implemented resource for connections with create, read, update, delete, and import state capabilities.
- Defined models for connection parameters, details, and credentials.
- Established unit tests for data source and resource to ensure functionality.
- Created schema definitions for connection attributes including connectivity type, privacy level, and credential details.
- Integrated timeout handling for resource operations.
- Added connection models and schema definitions for managing connections.
- Implemented resource connection CRUD operations with appropriate logging and error handling.
- Created unit tests for connection resource and data source to ensure functionality.
- Defined connection parameters, credential details, and privacy levels in the schema.
- Established validation rules for connection attributes and credential types.
- Integrated timeout management for connection operations.
@bartveenstra bartveenstra requested a review from a team as a code owner April 15, 2025 12:08
@bartveenstra bartveenstra changed the title Feature/connection models cleanup Feature: Create tenant level connections Apr 15, 2025
@bartveenstra
Copy link
Author

@microsoft-github-policy-service agree [company="Backbase"]

@bartveenstra bartveenstra changed the title Feature: Create tenant level connections feat: Create tenant level connections Apr 15, 2025
@bartveenstra
Copy link
Author

@microsoft-github-policy-service agree company="Backbase"

@DariuszPorowski
Copy link
Member

DariuszPorowski commented Apr 18, 2025

Hi @bartveenstra

Thank you for your PR, however currently we do not accept external contributions.

Quote from the Contributing Guide:

This project welcomes feedback and suggestions only via GitHub Issues. Pull Request (PR) contributions
will NOT be accepted at this time.

ref: https://github.com/microsoft/terraform-provider-fabric/blob/main/CONTRIBUTING.md#-contributing-guide

Regardless of that we already working on connections (initial code is under feature branch: https://github.com/microsoft/terraform-provider-fabric/tree/feat/connection

The reason why connections are not in the provider today is we are waiting for clarification from feature team for certain cases related to encrypted credentials (used for OnPremisesGateway connection type) which may affect the final design of the HCL scheme and any later changes are very painful due to the potential breaking changes in the schema.

CC @badeamarjieh @OrBaubergMicrosoft

@DariuszPorowski DariuszPorowski mentioned this pull request Apr 18, 2025
1 task
This was referenced Jun 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants