-
Notifications
You must be signed in to change notification settings - Fork 15
feat(item): enhance update item to handle ItemDisplayNameNotAvailableYet when display name is reserved for 5 min #501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(item): enhance update item to handle ItemDisplayNameNotAvailableYet when display name is reserved for 5 min #501
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR enhances the update item functionality by introducing a retry mechanism to handle cases where an item's display name is reserved (returning the "ItemDisplayNameNotAvailableYet" error). Key changes include replacing direct calls to UpdateItem with RetryUpdateItem across several resource files and adding new retry functions and configurations in helpers.go.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
internal/pkg/fabricitem/resource_item_properties.go | Replaces direct UpdateItem call with RetryUpdateItem |
internal/pkg/fabricitem/resource_item_definition_properties.go | Replaces direct UpdateItem call with RetryUpdateItem |
internal/pkg/fabricitem/resource_item_definition.go | Replaces direct UpdateItem call with RetryUpdateItem |
internal/pkg/fabricitem/resource_item_config_properties.go | Replaces direct UpdateItem call with RetryUpdateItem |
internal/pkg/fabricitem/resource_item_config_definition_properties.go | Replaces direct UpdateItem call with RetryUpdateItem |
internal/pkg/fabricitem/resource_item.go | Replaces direct UpdateItem call with RetryUpdateItem |
internal/pkg/fabricitem/helpers.go | Adds retry logic functions and configuration for handling update errors |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add tests
Minimum allowed line rate is |
β¦r-fabric into dev/badeamarjieh/handle_name_temporarily_unavailable
β¦r-fabric into dev/badeamarjieh/handle_name_temporarily_unavailable
Codecov ReportAll modified and coverable lines are covered by tests β
Additional details and impacted files@@ Coverage Diff @@
## main #501 +/- ##
===========================
===========================
β View full report in Codecov by Sentry. |
π₯ Pull Request
β What are you trying to address
ItemDisplayNameNotAvailableYet