PHP autoindent with arrays is even more stupid

[php4fan]

Does this issue occur when all extensions are disabled?: Yes

• VS Code Version: 1.99.3
• OS Version: Manjaro Linux

Steps to Reproduce:

Say I want to write an array like the following:

<?php

$array = [
    [
        "one",
        "two"
    ]
];

This is not only a very reasonable, but also very standard and common way to indent an array of arrays.

I start typing this:

<?php

$array = [

and immediately, the IDE adds the closing ], and the cursor is between the two []. So I hit enter and I get this, as expected:

(the arrow highlights where the text cursor is).

So I type the next [ and hit Enter again and I get this:

again as expected.

I fill in the array and move the text cursor to the end:

So far so good.

Now, the moment I add the semicolon, something completely idiotic happens:

A completely nonsensical indentation is added before the ], which had been in the right place all along:

This is infinitely more stupid than #248227

[hawkticehurst]

Hi @php4fan, do you have an extension installed that provides PHP formatting / language support? It's very likely these formatting issues are coming from that extension and you would need to report this issue to them.

[php4fan]

Hi @php4fan, do you have an extension installed that provides PHP formatting / language support? It's very likely these formatting issues are coming from that extension and you would need to report this issue to them.

As I said in the report:

Does this issue occur when all extensions are disabled?: Yes

I do have the Devsense PHP extension, but I did the extension bisect and the issue reproduces with all extensions disabled.

Does it not reproduce for you?

[RedCMD]

@hawkticehurst this is not caused by any formatter

caused by a bad "decreaseIndentPattern"

vscode/extensions/php/language-configuration.json

Line 97 in 83d1ff7

"decreaseIndentPattern": "^(.*\\*\\/)?\\s*((\\})|(\\)+[;,])|(\\]\\)*[;,])|\\b(else:)|\\b((end(if|for(each)?|while|switch));))"

ddb6d23#diff-ac07ec55577b026b3b3a7e232c1646e804578a280f703c5bbfeb5a0aeedf7c68R25

@roblourens what's with basic brackets being in the indent rules?
doesn't the brackets in "brackets" already handle the indentation correctly for normal brackets?

@php4fan you can place an optional comma on the purple bracket ], as a workaround

[roblourens]

Honestly I haven't had to look at these patterns in a long time 😅

You can work around it by setting "editor.autoIndent": "brackets". I'm not going to invest a lot of time into this because the eventual plan is to move off the textmate engine and onto treesitter (see https://code.visualstudio.com/updates/v1_97#_treesitter-based-syntax-highlighting-for-typescript) but we don't support PHP here yet.

[RedCMD]

removing the two highlighted sections should fix all bracket indentation bugs

otherwise can just add ? to (\\]\\)*[;,]) to fix just this bug

maybe @aiday-mar would like to take a look