Code ignores "Turn off all notificationis from <extension>", and still displays notifications

[working-name]

Does this issue occur when all extensions are disabled?: Yes.
^ Just in case you are deleting my submissions automatically, rather than manually: No, you need an extension to trigger the notifications. That is the whole point here. facepalm

🪓 If you answered No above, use 'Help: Start Extension Bisect' from Command Palette to try to identify the cause. NOT APPLICABLE
📣 Issues caused by an extension ... NOT APPLICABLE All extensions that send warning notification will go through regardless of the user turning all notifications off for that extension. This is VS Code, not the extension.

• VS Code Version: 1.101.0 (user setup)
• OS Version: Windows_NT x64 10.0.26100

Steps to Reproduce:

1. Install an extension that's notifications happy, like Markdown Preview Enhanced
2. Open a new file, don't save it, set it to markdown, type anything in it, and start preview
3. Select all, then delete the text in the non-saved file. The extension will scream at you: "no such file or directory open '/Untitled-1'", which is normal, and no action should be taken by the user.
4. Type more stuff, select all, delete, and reproduce the notification.

I tried debugging it, I can't go down the call stack enough to get to the extension, but it's clear that this is VSCode ignoring the user's preference of not being bugged with notifications from the specific extension.

This incessant bugging with notifications can be recreated with any extension that sends warnings (some valid, others not so much). I already selected turn off all notifications from the extension, and I therefore expect ALL notifications to be off.

[bpasero]

The filter does not apply to errors because we think that errors are important enough to still be shown:

vscode/src/vs/workbench/common/notifications.ts

Lines 494 to 500 in c2b76e0

	if ((priority === NotificationPriority.DEFAULT || priority === NotificationPriority.OPTIONAL) && severity !== Severity.Error) {
	if (filter.global === NotificationsFilter.ERROR) {
	priority = NotificationPriority.SILENT; // filtered globally
	} else if (isNotificationSource(notification.source) && filter.sources.get(notification.source.id) === NotificationsFilter.ERROR) {
	priority = NotificationPriority.SILENT; // filtered by source
	}
	}

[working-name]

I can see where that would be useful at times (like when trying to debug an extension), but I'd appreciate an option to turn off all notifications, including those about self-implosion.

I'm sorry, but not all errors are valid errors. This particular extension for example, does not need to raise an error for an expected result. Same thing goes for Continue.dev, which throws an error when you have autocomplete on, but no configured LLM for that part. These are many situations that should fail gracefully. Only send an error notification when a truly critical issue has occurred, like being unable to write the file after I hit CTRL/CMD + S.

If an extension isn't working right, I can look at the extension host output. But as it stands right now, these error level notifications do not make it in the logs. Less useful, in my opinion.

[bpasero]

Yeah but the challenge is that we don't actually know if a notification is "useful" or "spam". Thus we decided that error notifications are always let through because it indicates that the extension is not running well. If it gets too annoying I would report an issue to the extension.

[working-name]

It does, unfortunately. :( Okay, thank you.