mcp: fix compilation error with paths and minification

[connor4312]

Maybe?

[bpasero]

Do we have an understanding what is going on that requires this change?

[bpasero]

@mjbvz can you have a look please, the main CI fails with:

[core-ci                  ] [18:20:07] Error: /Users/cloudtest/vss/_work/1/s/src/vs/workbench/contrib/mcp/common/discovery/configMcpDiscovery.ts(123,12): Property '$5' does not exist on type 'IPath | typeof import("/Users/cloudtest/vss/_work/1/s/src/vs/base/common/path", { with: { "resolution-mode": "import" } })'.
[core-ci                  ] [18:20:07] Error: /Users/cloudtest/vss/_work/1/s/src/vs/workbench/contrib/mcp/common/discovery/configMcpDiscovery.ts(123,28): Property '$6' does not exist on type 'IPath | typeof import("/Users/cloudtest/vss/_work/1/s/src/vs/base/common/path", { with: { "resolution-mode": "import" } })'.
[core-ci                  ] [18:20:07] Finished compilation with 2 errors after 660200 ms
[core-ci                  ] [18:20:07] Error: /Users/cloudtest/vss/_work/1/s/src/vs/workbench/contrib/mcp/common/discovery/configMcpDiscovery.ts(123,12): Property '$5' does not exist on type 'IPath | typeof import("/Users/cloudtest/vss/_work/1/s/src/vs/base/common/path", { with: { "resolution-mode": "import" } })'.
[core-ci                  ] [18:20:07] Error: /Users/cloudtest/vss/_work/1/s/src/vs/workbench/contrib/mcp/common/discovery/configMcpDiscovery.ts(123,28): Property '$6' does not exist on type 'IPath | typeof import("/Users/cloudtest/vss/_work/1/s/src/vs/base/common/path", { with: { "resolution-mode": "import" } })'.
[core-ci                  ] [18:20:07] Finished compilation with 2 errors after 660201 ms
[core-ci                  ] [18:20:07] 'core-ci' errored after 11 min
[core-ci                  ] [18:20:07] Error: Found 2 errors
[core-ci                  ]     at Stream.<anonymous> (/Users/cloudtest/vss/_work/1/s/build/lib/reporter.js:94:29)
[core-ci                  ]     at _end (/Users/cloudtest/vss/_work/1/s/node_modules/through/index.js:65:9)
[core-ci                  ]     at stream.end (/Users/cloudtest/vss/_work/1/s/node_modules/through/index.js:74:5)
[core-ci                  ]     at Stream.onend (node:internal/streams/legacy:48:10)
[core-ci                  ]     at Stream.emit (node:events:530:35)
[core-ci                  ]     at Stream.emit (node:domain:552:15)
[core-ci                  ]     at drain (/Users/cloudtest/vss/_work/1/s/node_modules/through/index.js:34:23)
[core-ci                  ]     at stream.queue.stream.push (/Users/cloudtest/vss/_work/1/s/node_modules/through/index.js:45:5)
[core-ci                  ]     at Stream.end (/Users/cloudtest/vss/_work/1/s/node_modules/through/index.js:15:35)
[core-ci                  ]     at _end (/Users/cloudtest/vss/_work/1/s/node_modules/through/index.js:65:9)

[connor4312]

Do we have an understanding what is going on that requires this change?

I had previously import * as path from 'path' and used both path.win32, path.posix, and path itself as a value. So something in that broke 🤷