Skip to content

Remove disabled "No accounts requested yet..." menu item from accounts menu #251511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 16, 2025

Conversation

Copilot
Copy link
Contributor

@Copilot Copilot AI commented Jun 15, 2025

Removes the unnecessary disabled menu item "No accounts requested yet..." that appears at the bottom of the accounts menu on fresh VS Code installations.

Before - showing disabled menu item

Changes Made

  • Removed _placeholderMenuItem property that created the disabled menu item
  • Removed event handlers that managed adding/removing the placeholder based on authentication provider registration
  • Cleaned up now-unused helper methods and empty handlers

Impact

  • User Experience: Cleaner accounts menu without confusing disabled items
  • Code: Simplified authentication contribution logic by removing 35 lines of placeholder management code
  • Compatibility: No breaking changes - all existing authentication functionality remains intact

The disabled menu item provided no value to users and only added visual clutter. Users who need authentication will see the relevant options when extensions or features request authentication providers.

Fixes #228948.

Warning

Firewall rules blocked me from connecting to one or more addresses

I tried to connect to the following addresses, but was blocked by firewall rules:

  • electronjs.org
    • Triggering command: node-gyp (dns block)

If you need me to access, download, or install something from one of these locations, you can either:


💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.

Copilot AI and others added 2 commits June 15, 2025 01:28
Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
…nu item

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
@Copilot Copilot AI changed the title [WIP] "No accounts requested yet..." disabled menu item? Remove disabled "No accounts requested yet..." menu item from accounts menu Jun 15, 2025
@Copilot Copilot AI requested a review from TylerLeonhardt June 15, 2025 01:30
Copilot finished work on behalf of TylerLeonhardt June 15, 2025 01:30
@TylerLeonhardt TylerLeonhardt marked this pull request as ready for review June 15, 2025 01:45
@vs-code-engineering vs-code-engineering bot added this to the June 2025 milestone Jun 15, 2025
bpasero
bpasero previously approved these changes Jun 15, 2025
@TylerLeonhardt
Copy link
Member

Fix these errors:

[tsec-compile-check ] src/vs/workbench/contrib/authentication/browser/authentication.contribution.ts(6,22): error TS6133: 'IDisposable' is declared but its value is never read.
[tsec-compile-check ] src/vs/workbench/contrib/authentication/browser/authentication.contribution.ts(8,10): error TS6133: 'MenuId' is declared but its value is never read.
[tsec-compile-check ] src/vs/workbench/contrib/authentication/browser/authentication.contribution.ts(8,18): error TS6133: 'MenuRegistry' is declared but its value is never read.
[tsec-compile-check ] src/vs/workbench/contrib/authentication/browser/authentication.contribution.ts(10,1): error TS6133: 'ContextKeyExpr' is declared but its value is never read.
[tsec-compile-check ] src/vs/workbench/contrib/authentication/browser/authentication.contribution.ts(83,55): error TS6138: Property '_authenticationService' is declared but its value is never read.

…erties

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
Copy link
Contributor Author

Copilot AI commented Jun 16, 2025

Fix these errors:

[tsec-compile-check ] src/vs/workbench/contrib/authentication/browser/authentication.contribution.ts(6,22): error TS6133: 'IDisposable' is declared but its value is never ...

Fixed all TypeScript compilation errors by removing unused imports (IDisposable, MenuId, MenuRegistry, ContextKeyExpr, IAuthenticationService) and the unused _authenticationService property from the constructor. Commit: 9f0d1d6

Copilot finished work on behalf of TylerLeonhardt June 16, 2025 06:13
@TylerLeonhardt TylerLeonhardt merged commit 4bfe82a into main Jun 16, 2025
8 checks passed
@TylerLeonhardt TylerLeonhardt deleted the copilot/fix-228948 branch June 16, 2025 22:30
Subham-KRLX pushed a commit to Subham-KRLX/vscode that referenced this pull request Jun 17, 2025
…s menu (microsoft#251511)

* Initial plan for issue

* Remove disabled 'No accounts requested yet...' menu item

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>

* Clean up empty _registerHandlers method after removing placeholder menu item

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>

* Fix TypeScript compilation errors by removing unused imports and properties

Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>

---------

Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com>
Co-authored-by: TylerLeonhardt <2644648+TylerLeonhardt@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"No accounts requested yet..." disabled menu item?
5 participants