fix: PowerShell not working with username having Unicode #251534
Merged
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tyriar, could you please take a look at this fix? Thanks! |
Tyriar
approved these changes
Jun 16, 2025
TylerLeonhardt
approved these changes
Jun 16, 2025
| @@ -139,7 +139,7 @@ async function doResolveShellEnv(logService: ILogService, token: CancellationTok | |||
| // Older versions of PowerShell removes double quotes sometimes | |||
| // so we use "double single quotes" which is how you escape single | |||
| // quotes inside of a single quoted string. | |||
| command = `Write-Output '${mark}'; [System.Environment]::GetEnvironmentVariables() | ConvertTo-Json -Compress; Write-Output '${mark}'`; | |||
| command = `chcp 65001; Write-Output '${mark}'; [System.Environment]::GetEnvironmentVariables() | ConvertTo-Json -Compress; Write-Output '${mark}'`; | |||
There was a problem hiding this comment.
...wait does this run on macOS & Linux as well with PowerShell 7+? If so chcp is not available there and this will break.
There was a problem hiding this comment.
Oops, I tested chcp and it doesn't work on linux.
I noticed @Tyriar already fixed it, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #251478
On some computers, the default encoding of PowerShell is not utf8, which will cause the Unicode characters in the obtained environment variables to become garbled. Here we first set the encoding to utf8 to fix this issue.