Fix tooltip skipDelayDuration with disableHoverableContent #3562
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Scenario:
<Tooltip.Trigger>
's are0px
apart<Tooltip.Provider skipDelayDuration={0}>
<Tooltip.Root disableHoverableContent>
(not sure why this is required to reproduce)Problem:
delayDuration
will be skipped, even thoughskipDelayDuration
is 0Solution
Before:
skipDelayDuration
was set to0
:onOpen
setsskipDelayTimerRef.current = false
onClose
waits to setskipDelayTimerRef.current = true
for0ms
insetTimeout()
skipDelayTimerRef.current
isfalse
After:
skipDelayDuration
is<= 0
:onOpen
never setskipDelayTimerRef.current = false
onClose
instantly setskipDelayTimerRef.current = true
skipDelayDuration
changed betweenonOpen
andonClose
Additional Fix
The cleanup code for
skipDelayTimerRef
is always using the initial value even as many different timers may be set/cleared.After: Always clear the last value of
skipDelayTimerRef