progress bar added for training and validation, on screen logs structured #204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
…passing issue when only evaluating any pretrained model.
…nal logger and the progress bar
|
Hi @shubsraj , I created a new PR shubsraj#1 which mainly adds a config parameter 
|
Add config parameter `progress_bar`
nok
reviewed
May 26, 2025
| start_steps = epoch * num_training_steps_per_epoch | ||
|
|
||
| print("Grad accum steps: ", args.grad_accum_steps) | ||
| print("Total batch size: ", batch_size * utils.get_world_size()) | ||
| # print("Grad accum steps: ", args.grad_accum_steps) |
There was a problem hiding this comment.
I'm not sure how helpful these print statements are in the current context, so I left them unchanged. I'll leave it to a core maintainer to decide whether they should be removed or kept.
There was a problem hiding this comment.
Every time before an epoch, the same info was printed, so I shifted it to the main code to print it once, before the start of the training while adding a progress bar.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ured.
Description
A progress bar has been added for training and validation processes, allowing better monitoring of training.
How has this change been tested, please provide a testcase or example of how you tested the change?
YOUR_ANSWER
no special change, just created a progress bar using tqdm and implemented in the main engine code for one epoch and the evaluate function, which adds structure to the logs and making it easier to read.
For example, documentation changes, usability, usage/costs, secrets, etc.
Docs
No change in the documentation
