Skip to content

Meta: override default issue class to display GitHub issue links #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

miketaylr
Copy link
Member

@miketaylr miketaylr commented May 31, 2025

Fixes #273


Preview | Diff

@miketaylr miketaylr requested a review from karlcow May 31, 2025 16:47
@miketaylr
Copy link
Member Author

Starting commit snapshot...
LINE 942:7: Saw an end tag </td>, but there were unclosed elements remaining before the nearest matching start tag (at 934:7).
Open tags: <table> at 926:1, <tbody> at 9[31](https://github.com/whatwg/compat/actions/runs/15365640619/job/43238184225?pr=274#step:5:32):3, <tr> at 932:5, <td> at 934:7, <code> at 938:8
LINE 943:5: Saw an end tag </tr>, but there were unclosed elements remaining before the nearest matching start tag (at 9[32](https://github.com/whatwg/compat/actions/runs/15365640619/job/43238184225?pr=274#step:5:33):5).
Open tags: <table> at 926:1, <tbody> at 931:3, <tr> at 932:5, <td> at 934:7, <code> at 938:8
LINE 944:3: Saw an end tag </tbody>, but there were unclosed elements remaining before the nearest matching start tag (at 931:3).
Open tags: <table> at 926:1, <tbody> at 931:3, <tr> at 932:5, <td> at 9[34](https://github.com/whatwg/compat/actions/runs/15365640619/job/43238184225?pr=274#step:5:35):7, <code> at 938:8
LINE 945:1: Saw an end tag </table>, but there were unclosed elements remaining before the nearest matching start tag (at 926:1).
Open tags: <table> at 926:1, <tbody> at 931:3, <tr> at 932:5, <td> at 934:7, <code> at 938:8
LINE 145: 'Name' key should contain just the property/descriptor name, or a comma-separated list. Found markup:
  '@media/-webkit-device-pixel-ratio'
LINE 182: 'Name' key should contain just the property/descriptor name, or a comma-separated list. Found markup:
  '@media/-webkit-transform-3d'
 ✘  Did not generate, due to errors exceeding the allowed error level.
make: *** [Makefile:23: deploy] Error 2
Error: Process completed with exit code 2.

OK - will fix then.

Copy link
Member

@karlcow karlcow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@karlcow
Copy link
Member

karlcow commented Jun 1, 2025

There's a build failure on the other hand.

Starting commit snapshot...
LINE 942:7: Saw an end tag </td>, but there were unclosed elements remaining before the nearest matching start tag (at 934:7).
Open tags: <table> at 926:1, <tbody> at 931:3, <tr> at 932:5, <td> at 934:7, <code> at 938:8
LINE 943:5: Saw an end tag </tr>, but there were unclosed elements remaining before the nearest matching start tag (at 932:5).
Open tags: <table> at 926:1, <tbody> at 931:3, <tr> at 932:5, <td> at 934:7, <code> at 938:8
LINE 944:3: Saw an end tag </tbody>, but there were unclosed elements remaining before the nearest matching start tag (at 931:3).
Open tags: <table> at 926:1, <tbody> at 931:3, <tr> at 932:5, <td> at 934:7, <code> at 938:8
LINE 945:1: Saw an end tag </table>, but there were unclosed elements remaining before the nearest matching start tag (at 926:1).
Open tags: <table> at 926:1, <tbody> at 931:3, <tr> at 932:5, <td> at 934:7, <code> at 938:8
LINE 145: 'Name' key should contain just the property/descriptor name, or a comma-separated list. Found markup:
  '@media/-webkit-device-pixel-ratio'
LINE 182: 'Name' key should contain just the property/descriptor name, or a comma-separated list. Found markup:
  '@media/-webkit-transform-3d'
 ✘  Did not generate, due to errors exceeding the allowed error level.
make: *** [Makefile:23: deploy] Error 2
Error: Process completed with exit code 2.

@miketaylr
Copy link
Member Author

miketaylr commented Jun 2, 2025

LINE 145: 'Name' key should contain just the property/descriptor name, or a comma-separated list. Found markup: '@media/-webkit-device-pixel-ratio' feels like an over-eager regular expression...

https://github.com/speced/bikeshed/blob/de38ee2b57af487f1c3f1bc5c47670dcf3384396/bikeshed/datablocks.py#L582-L642

@miketaylr
Copy link
Member Author

We're slightly more correct now, but it's still not happy:

LINE 145: 'Name' key should contain just the property/descriptor name, or a comma-separated list. Found markup: '-webkit-device-pixel-ratio'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Warning for keyword mappings is nonsensical. (probably just a typo)
2 participants