-
Notifications
You must be signed in to change notification settings - Fork 2.9k
Make it optional to show UI for <a ping> #11329
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
If the spec were to no longer recommend user transparency, then you should simultaneously remove the part of the note in this section that recommends that authors use the For many years this feature was justified as potentially providing privacy benefits, but if those requirements are removed, you could at least remove the pretense. |
Good point, fixed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but let's wait for a bit to get more eyes on this.
Thanks for aligning the spec with reality here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I like tying it to script execution, do we have any indication that it's going to be followed? If we want that to be model we should require it, but it's not entirely clear to me it's worth doing.
I'm not aware of plans of it being implemented for Scripting is disabled check is used by lazy-loading, which is implemented (see wpt). However, CSS can probably be used to "ping" when a link is clicked (with Either the CSS features need to also be have a scripting-disabled check, or the HTML features should keep working when scripting is disabled, I think. |
I removed the scripting is disabled check. |
I think we've waited long enough; feel free to merge! |
Did it seem like we had consensus on #11309? I've tried my best to clarify the potential harm to users and privacy-friendly sites. |
Yes, you've made your position clear; thank you for doing that! That doesn't prevent merging changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a couple of nits so the paragraph is annotated in the usual way (and then I made that overall annotation more consistent).
Fixes #11309.
(See WHATWG Working Mode: Changes for more details.)
/infrastructure.html ( diff )
/links.html ( diff )
/system-state.html ( diff )
/web-messaging.html ( diff )
/webappapis.html ( diff )