Skip to content

Reword popover "invoker" terminology to "control" or "source" where appropriate. #11383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

keithamus
Copy link
Contributor

@keithamus keithamus commented Jun 17, 2025

This editorial change attempts to fix #11352, by dropping the use of the word "invoker", instead referring to the invoker as the "control". However for some algorithms "control" feels a little generic as a variable and so I opted to use "source" as it also aligns better to the IDL definitions which have a .source property to refer to said control.

IOW, a popover is controlled by a "popover control", but "source" is a specifically provided "popover control".

This also renames the "invoker command steps" and "is valid invoker command steps" to "comamndfor steps" and "is valid commandfor steps" respectively.


/form-elements.html ( diff )
/interaction.html ( diff )
/interactive-elements.html ( diff )
/popover.html ( diff )

@keithamus keithamus added the editorial Changes that do not affect how the standard is understood label Jun 17, 2025
@domenic
Copy link
Member

domenic commented Jun 18, 2025

Thanks for doing this! I hadn't realized there were cases where "source" was inappropriate; could you briefly explain that for me?

@keithamus
Copy link
Contributor Author

keithamus commented Jun 18, 2025

I think "source" works fine in instances where it refers to the IDL property. In other cases it felt a little ambiguous, for example renaming "popover invoker" to "popover source" sounds as though its the element with the popover attribute, rather than the button controlling the popover, so here I felt "popover control" was a better fit. Likewise "invoker command steps" would be odd to be named "source command steps", but also "control command steps" is equally nonsensical, so "commandfor steps" seems to be more illustrative IMO.

As an aside I don't know why CI isn't generating the preview links for this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editorial Changes that do not affect how the standard is understood
Development

Successfully merging this pull request may close these issues.

Drop usage of invoker term from spec
2 participants