Skip to content

Extra methods plus ergonomic updates #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

unsignedint
Copy link

Hiya, this PR brings in #1 from @nireno and updates the docs and adds a couple of other methods.

nireno and others added 14 commits March 2, 2020 09:39
Previously we were requiring the entire top level firebase module. This
generates a warning in the console "It looks like you're using the
development build of the Firebase JS SDK".

This fix simply follows the recommendations detailed in the warning message
which is to specifically require "firebase/app".
Note: QuerySnapshot.get technically returns a
[QueryDocumentSnapshot](https://firebase.google.com/docs/reference/js/firebase.firestore.QueryDocumentSnapshot)
but from the docs it offers the same API surface as a DocumentSnapshot.
Additions and modifications to bindings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants