Fix: link to Chinese version should not be broken #676
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Fechin is this correct/desired link? Or should the broken link be removed instead? Let me know and I can update the PR if required. |
|
I notice the link to the Chinese version has been removed in the recent UI component refactor, so this PR is now obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The link to the Chinese version (中文版) on the main page is broken. It links to a non-existent
/zh-CN/path.The main Chinese fork of this project is https://wangchujiang.com/reference/. At least as far as I can tell - it was created explicitly to translate https://cheatsheets.zip/ and has the appropriate link-backs. Although the the code-bases have clearly diverged, it still seems to be the most appropriate link to use.
I have updated the link accordingly.