Skip to content

Commit 94ef8a7

Browse files
HenrichHenrich
authored andcommitted
Fix typo
1 parent ac5970d commit 94ef8a7

File tree

4 files changed

+24
-18
lines changed

4 files changed

+24
-18
lines changed

src/CanTestBroadcasting.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66

77
trait CanTestBroadcasting
88
{
9-
public function assertEventBroadcasted($event, $channels = null, $count = null)
9+
public function assertEventHasBroadcast($event, $channels = null, $count = null)
1010
{
1111
$broadcaster = resolve(TestBroadcaster::class);
1212

@@ -33,7 +33,7 @@ public function assertEventBroadcasted($event, $channels = null, $count = null)
3333
$broadcasts = $broadcaster->getBroadcasts();
3434
$broadcastCount = count($broadcasts);
3535
$evtStr = Str::plural('event', $broadcastCount);
36-
$message .= "\n$broadcastCount $evtStr was broadcasted: " . json_encode($broadcasts);
36+
$message .= "\n$broadcastCount $evtStr was broadcast: " . json_encode($broadcasts);
3737

3838
$this->assertTrue($broadcaster->contains($event, $channels, $count), $message);
3939
}

src/TestBroadcaster.php

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -53,9 +53,10 @@ public function validAuthenticationResponse($request, $result)
5353
/**
5454
* Return if the broadcaster contains event.
5555
*
56-
* @param string $event
57-
* @param mixed $channel
58-
*
56+
* @param string $event
57+
* @param null $channels
58+
* @param null $count
59+
* @param array|null $payload
5960
* @return bool
6061
*/
6162
public function contains(string $event, $channels = null, $count = null, array $payload = null): bool
@@ -93,7 +94,7 @@ private function broadcastContainsAllChannels(array $broadcast, $channels): bool
9394
if (! is_array($channels)) {
9495
return $this->broadcastContainsChannel($broadcast, $channels);
9596
}
96-
97+
9798
foreach ($channels as $channel) {
9899
if (! $this->broadcastContainsChannel($broadcast, $channel)) {
99100
return false;

src/TestBroadcasterFacade.php

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,12 @@
55
use Illuminate\Support\Facades\Facade;
66

77
/**
8-
* @see \Jlndk\TestBroadcaster\TestBroadcaster
8+
* @method static void broadcast(array $channels, $event, array $payload = [])
9+
* @method static bool contains(string $event, $channels = null, $count = null, array $payload = null)
10+
* @method static bool broadcastContainsAllChannels(array $broadcast, $channels)
11+
* @method static bool broadcastContainsChannel(array $broadcast, string $channel)
12+
*
13+
* @see \Genl\TestBroadcaster\TestBroadcaster
914
*/
1015
class TestBroadcasterFacade extends Facade
1116
{

tests/CanTestBroadcastingTest.php

Lines changed: 11 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -9,17 +9,17 @@ class CanTestBroadcastingTest extends TestCase
99
/**
1010
* @test
1111
*/
12-
public function it_can_assert_when_an_event_is_broadcasted()
12+
public function it_can_assert_when_an_event_is_broadcast()
1313
{
1414
try {
15-
$this->assertEventBroadcasted(TestEvent::class);
15+
$this->assertEventHasBroadcast(TestEvent::class);
1616
$this->fail("assertEventBroadcasted asserted that an event was broadcasted when it wasn't");
1717
} catch (ExpectationFailedException $e) {
1818
}
1919

2020
event(new TestEvent());
2121

22-
$this->assertEventBroadcasted(TestEvent::class);
22+
$this->assertEventHasBroadcast(TestEvent::class);
2323
}
2424

2525
/**
@@ -28,22 +28,22 @@ public function it_can_assert_when_an_event_is_broadcasted()
2828
public function it_can_assert_if_an_event_was_broadcasted_a_given_amount_of_times()
2929
{
3030
try {
31-
$this->assertEventBroadcasted(TestEvent::class, 1);
31+
$this->assertEventHasBroadcast(TestEvent::class, 1);
3232
$this->fail("assertEventBroadcasted asserted that an event was broadcasted once when it wasn't");
3333
} catch (ExpectationFailedException $e) {
3434
}
3535

3636
event(new TestEvent());
37-
$this->assertEventBroadcasted(TestEvent::class, 1);
37+
$this->assertEventHasBroadcast(TestEvent::class, 1);
3838

3939
try {
40-
$this->assertEventBroadcasted(TestEvent::class, 2);
40+
$this->assertEventHasBroadcast(TestEvent::class, 2);
4141
$this->fail("assertEventBroadcasted asserted that an event was broadcasted twice when only was broadcasted once");
4242
} catch (ExpectationFailedException $e) {
4343
}
4444

4545
event(new TestEvent());
46-
$this->assertEventBroadcasted(TestEvent::class, 2);
46+
$this->assertEventHasBroadcast(TestEvent::class, 2);
4747
}
4848

4949
/**
@@ -53,10 +53,10 @@ public function it_can_assert_if_an_event_was_broadcasted_on_a_single_channel()
5353
{
5454
event(new TestEvent());
5555

56-
$this->assertEventBroadcasted(TestEvent::class, 'private-channel-name');
56+
$this->assertEventHasBroadcast(TestEvent::class, 'private-channel-name');
5757

5858
try {
59-
$this->assertEventBroadcasted(TestEvent::class, 'somethingelse-fake-channel');
59+
$this->assertEventHasBroadcast(TestEvent::class, 'somethingelse-fake-channel');
6060
$this->fail("assertEventBroadcasted asserted that an event was broadcasted on a given channel when it wasn't");
6161
} catch (ExpectationFailedException $e) {
6262
}
@@ -69,10 +69,10 @@ public function it_can_assert_if_an_event_was_broadcasted_on_multiple_channels()
6969
{
7070
event(new TestEvent());
7171

72-
$this->assertEventBroadcasted(TestEvent::class, ['private-channel-name', 'private-another-channel-name']);
72+
$this->assertEventHasBroadcast(TestEvent::class, ['private-channel-name', 'private-another-channel-name']);
7373

7474
try {
75-
$this->assertEventBroadcasted(TestEvent::class, [
75+
$this->assertEventHasBroadcast(TestEvent::class, [
7676
'private-channel-name',
7777
'somethingelse-fake-channel',
7878
]);

0 commit comments

Comments
 (0)