Improve FadeIn and FadeOut classes with error handling and type safety #4308
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -20,10 +20,9 @@ | |||
| ] | |||
|
|
|||
| import numpy as np | |||
| from typing_extensions import Any | |||
| from typing import Any, Union | |||
Check notice
Code scanning / CodeQL
Unused import Note
OliverStrait
suggested changes
Jun 28, 2025
| try: | ||
| self.interpolate(0) | ||
| except Exception as e: | ||
| raise RuntimeError(f"Error during cleanup interpolation: {e}") |
There was a problem hiding this comment.
Does this really add value?
Anyway, this is correct way to write these kinds: raise RuntimeError(f"Error during cleanup interpolation") from e
| @@ -143,7 +169,7 @@ def create_starting_mobject(self) -> Mobject: | |||
|
|
|||
|
|
|||
| class FadeOut(_Fade): | |||
| r"""Fade out :class:`~.Mobject` s. | |||
| r"""Fade out :class:`~.Mobject` s. | |||
| return faded_mobject | ||
|
|
||
|
|
||
| class FadeIn(_Fade): | ||
| r"""Fade in :class:`~.Mobject` s. | ||
| r"""Fade in :class:`~.Mobject` s. |
| super().__init__(mobject, **kwargs) | ||
|
|
||
| def _create_faded_mobject(self, fadeIn: bool) -> Mobject: | ||
| """Create a faded, shifted and scaled copy of the mobject. | ||
| """Create a faded, shifted and scaled copy of the mobject. |
|
|
||
| faded_mobject = self.mobject.copy() # type: ignore[assignment] | ||
|
|
||
| if not isinstance(faded_mobject, Mobject): |
There was a problem hiding this comment.
This check is redudant because root-Class does not allow content to be anything else than Mobject.
And if copy cannot return same type, then it is not problem in here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improved the
FadeInandFadeOutanimation classes by adding error handling and type safety. Specifically, it introduces checks for the validity ofmobjects,shift,target_position, andscaleparameters, raising exceptions when incorrect types or values are provided. The creation of faded mobject copies is now validated to prevent unexpected runtime errors. Additionally, the scene cleanup process includes a try/except block aroundinterpolate(0)to handle potential failures gracefully.