Skip to content

Add type annotations to mobject/svg/brace.py and default to label_constructor=Text in BraceText #4309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jul 24, 2025

Conversation

henrikmidtiby
Copy link
Contributor

Overview: What does this pull request change?

Type annotations were added to the brace.py file.

Reviewer Checklist

  • The PR title is descriptive enough for the changelog, and the PR is labeled correctly
  • If applicable: newly added non-private functions and classes have a docstring including a short summary and a PARAMETERS section
  • If applicable: newly added functions and classes are tested

Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I just reviewed and left some suggestions:

@github-project-automation github-project-automation bot moved this from 🆕 New to 👀 In review in Dev Board Jun 25, 2025
Copy link
Contributor

@chopan050 chopan050 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for these changes!

@github-project-automation github-project-automation bot moved this from 👀 In review to 👍 To be merged in Dev Board Jul 24, 2025
@chopan050 chopan050 changed the title Added type annotations to mobject/svg/brace.py Add type annotations to mobject/svg/brace.py Jul 24, 2025
@chopan050 chopan050 enabled auto-merge (squash) July 24, 2025 21:16
@chopan050 chopan050 merged commit 047db45 into ManimCommunity:main Jul 24, 2025
22 checks passed
@github-project-automation github-project-automation bot moved this from 👍 To be merged to ✅ Done in Dev Board Jul 24, 2025
@chopan050 chopan050 changed the title Add type annotations to mobject/svg/brace.py Add type annotations to mobject/svg/brace.py and default to label_constructor=Text in BraceText Jul 24, 2025
@henrikmidtiby henrikmidtiby deleted the TypingBrace branch July 25, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants