Implement device and context properties for Event #618
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
/ok to test |
leofang
added
enhancement
leofang
reviewed
May 7, 2025
Comment on lines
116
to
117
| self._device_id = int(handle_return(driver.cuCtxGetDevice())) | ||
| self._ctx_handle = handle_return(driver.cuStreamGetCtx(self._mnff.handle)) |
There was a problem hiding this comment.
Let's avoid driver calls if possible to reduce overhead. The same info can be passed in from within the two public constructors (I think!) Device.create_event and Stream.record.
leofang
reviewed
May 7, 2025
rwgk
reviewed
May 8, 2025
cuda_core/tests/test_event.py
Outdated
| def test_event_device(init_cuda): | ||
| event = Device().create_event(options=EventOptions()) | ||
| device = event.device | ||
| assert isinstance(device, Device) |
There was a problem hiding this comment.
The docstring ...
Return the :obj:`~_device.Device` singleton associated with this event.
mentions "singleton". → Could this be
device = Device()
event = device.create_event(options=EventOptions())
assert event.device is device
?
|
/ok to test |
|
|
/ok to test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes #491
Checklist