Skip to content

Fix accident in cuda_bindings/cuda/bindings/_path_finder/supported_libs.py #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 27, 2025

Conversation

rwgk
Copy link
Collaborator

@rwgk rwgk commented May 23, 2025

Description

Discovered in passing. Adding test to ensure something like this does not slip in again.

Copy link
Contributor

copy-pr-bot bot commented May 23, 2025

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk rwgk self-assigned this May 23, 2025
@leofang leofang added this to the cuda-python 12-next, 11-next milestone May 23, 2025
@leofang leofang added bug Something isn't working P1 Medium priority - Should do cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements and removed bug Something isn't working labels May 23, 2025
@rwgk
Copy link
Collaborator Author

rwgk commented May 27, 2025

/ok to test

This comment has been minimized.

@rwgk rwgk marked this pull request as ready for review May 27, 2025 06:07
Copy link
Contributor

copy-pr-bot bot commented May 27, 2025

Auto-sync is disabled for ready for review pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@rwgk rwgk requested a review from kkraus14 May 27, 2025 06:07
@rwgk rwgk merged commit 1e5097c into NVIDIA:main May 27, 2025
53 checks passed
@rwgk rwgk deleted the path_finder_supported_libs_fix branch May 27, 2025 17:31
Copy link

Doc Preview CI
Preview removed because the pull request was closed or merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cuda.bindings Everything related to the cuda.bindings module enhancement Any code-related improvements P1 Medium priority - Should do
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants