Skip to content

Commit 192d077

Browse files
authored
Addressing grammatical nits and fixing typo in testing.md (#6550)
1 parent 82b73ed commit 192d077

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

docs/testing.md

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -300,7 +300,7 @@ And the relations
300300
The setting looks perfectly fine at first glance. However, it is not well defined.
301301
The forbidden right turn could be either a superfluous addition, forbidding the turn `cb` to `be`, or actually refer to the turn `ab` to `bd` to say that a turn is forbidden here.
302302

303-
To model turn-restrictions correctly and unique, we need to split segments that contribute to the restriction into the smallest possible parts.
303+
To model turn-restrictions correctly and uniquely, we need to split segments that contribute to the restriction into the smallest possible parts.
304304
E.g. the above scenario could correctly be expressed as:
305305

306306
```
@@ -360,7 +360,7 @@ When I route I should get
360360

361361
And the test reports `turn right` for the route `a->e`, where before it said `slight right`.
362362

363-
If you changed the turn angles, obviously you can expect changes in the distinction between `slight right` and `right`.
363+
If you change the turn angles, obviously you can expect changes in the distinction between `slight right` and `right`.
364364
In such a case it is, of course, reasonable to change the expected route to report `right` instead of `slight right`. You should consider inspecting the actual turn angles at `b` to see if you feel that change is justified.
365365

366366
However, you should never adjust the test itself.
@@ -390,9 +390,9 @@ In this case we would see a very slight turn angle. If your change now reports d
390390

391391
### Consider Post-Processing Impacts
392392

393-
Some changes you might see could look completely unrelated. To understand the impact of your changes, you can make use of the debugging utilities you can finde in `util/debug.hpp` (and potentially other related headers).
393+
Some changes you might see could look completely unrelated. To understand the impact of your changes, you can make use of the debugging utilities you can find in `util/debug.hpp` (and potentially other related headers).
394394

395-
If your test is inspecting a series of turns (remember, a turn not necessarily equals an instruction), you could see interaction with post-processing.
395+
If your test is inspecting a series of turns (remember, a turn does not necessarily equals an instruction), you could see interaction with post-processing.
396396
To see the unprocessed turns, you should print the steps at the end of step assembly (`assembleSteps` in `engine/guidance/assemble_steps.hpp`).
397397

398398
If you see unexpected changes, you can consider adding the `locations` field to your test to study what location a turn is reported at.

0 commit comments

Comments
 (0)