Skip to content

Converter Restructuring #1782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 154 commits into
base: master
Choose a base branch
from
Draft

Converter Restructuring #1782

wants to merge 154 commits into from

Conversation

heinezen
Copy link
Member

@heinezen heinezen commented May 28, 2025 •
edited
Loading

This PR aims to make the converter a bit more maintainable.

Depends on #1688

@heinezen heinezen added improvement Enhancement of an existing component lang: python Done in Python code area: assets Involved with assets (images, sounds, ...) labels May 28, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in openage converter May 28, 2025
@heinezen heinezen force-pushed the feature/converter_refactor branch 2 times, most recently from 303c613 to b5149f6 Compare May 31, 2025 02:19
@heinezen heinezen moved this from 📋 Backlog to 🏗 In progress in openage converter Jun 1, 2025
@heinezen heinezen force-pushed the feature/converter_refactor branch from 06991b0 to f9ec4ab Compare June 8, 2025 22:08
heinezen added 21 commits June 13, 2025 19:55
@heinezen
gamestate: Apply*Effect components.
1e6bf1b
@heinezen
gamestate: Create Apply*Effect components for new entities.
c503bc3
@heinezen
gamestate: API interface for Apply*Effect abilities.
7113107
@heinezen
gamestate: Fix checking ability parents.
1972b3c
@heinezen
gamestate: Add Resistance component.
cb16423
@heinezen
gamestate: Add basic system skeleton for applying effects.
d2132e8
@heinezen
gamestate: resistance definitions.
3161a08
@heinezen
gamestate: API layer for nyan effects.
fe0a961
@heinezen
gamestate: API layer for nyan resistances.
b1229be
@heinezen
gamestate: Add LineOfSight component.
2f18160
@heinezen
gamestate: LineOfSight definitions.
07f823f
@heinezen
gamestate: Add missing definitions for already implemented abilities.
6169871
@heinezen
gamestate: Allow fractional values for attributes.
a03c224
@heinezen
gamestate: Calculate application for discrete FLAC effects.
7c64774
@heinezen
gamestate: Decrease log level of unrecognized components.
286594c
@heinezen
gamestate: ApplyEffect command.
d71fe79
@heinezen
gamestate: Rename command classes and make them 'final'.
9a06cc2
@heinezen
gamestate: Add condition for ApplyEffect command in activity system.
edac4da
@heinezen
convert: Add new activity conditions for applying effects.
c2cd9ae
@heinezen
gamestate: Handle ApplyEffect in activity system.
d574b39
@heinezen
gamestate: Fix time calculations for applying effects.
a1846f1
heinezen added 29 commits June 13, 2025 19:55
@heinezen
convert: Move DE2AbilitySubprocessor methods into separate files.
5c3686d
@heinezen
convert: Refactor DE2CivSubprocessor into separate files.
8f5eeab
@heinezen
convert: Refactor DE2MediaSubprocessor into separate files.
07a1791
@heinezen
convert: Refactor DE2NyanSubprocessor into separate files.
1dcc022
@heinezen
convert: Refactor DE2Processor into separate files.
d6a59d1
@heinezen
convert: Refactor DE2TechSubprocessor into separate files.
a8527a9
@heinezen
convert: Refactor DE2UpgradeAttributeSubprocessor into separate files.
51ce634
@heinezen
convert: Refactor DE2UpgradeResourceSubprocessor into separate files.
c4e66b7
@heinezen
convert: Refactor HD processor classes into separate files.
a8db7ee
@heinezen
convert: Refactor RoRAbilitySubprocessor into separate files.
cad42c2
@heinezen
convert: Refactor RoRAuxiliarySubprocessor into separate files.
fc405d5
@heinezen
convert: Refactor RoRCivSubprocessor into separate files.
d8513dd
@heinezen
convert: Refactor RoRNyanSubprocessor into separate files.
ba906e3
@heinezen
convert: Refactor RoRPregenSubprocessor into separate files.
273c799
@heinezen
convert: Refactor RoRProcessor into separate files.
9178c44
@heinezen
convert: Refactor RoRTechSubprocessor into separate files.
d741ba7
@heinezen
convert: Refactor RoRUpgradeAbilitySubprocessor into separate files.
56f95bb
@heinezen
convert: Refactor RoRUpgradeAttributeSubprocessor into separate files.
37865b9
@heinezen
convert: Refactor RoRUpgradeResourceSubprocessor into separate files.
e78bb23
@heinezen
convert: Fix missing garrison empty condition in SWGB.
ee61b81
@heinezen
convert: Refactor SWGBCCAbilitySubprocessor into separate files.
f1eea76
@heinezen
convert: Refactor SWBGCCAuxiliarySubprocessor into separate files.
9dec9bb
@heinezen
convert: Refactor SWBGCCCivSubprocessor into separate files.
83faa9e
@heinezen
convert: Refactor SWGBCCNyanSubprocessor into separate files.
e10d313
@heinezen
convert: Refactor SWGBCCPregenSubprocessor into separate files.
5b78903
@heinezen
convert: Refactor SWGBCCProcessor into separate files.
3ee1608
@heinezen
convert: Refactor SWGBCCTechSubprocessor into separate files.
fa4e4fa
@heinezen
convert: Refactor SWBGCCUpgradeAttributeSubprocessor into separate fi…
65a9490 
…les.
@heinezen
convert: Refactor SWBGCCUpgradeResourceSubprocessor into separate files.
f217db5
@heinezen heinezen force-pushed the feature/converter_refactor branch from bf4d445 to f217db5 Compare June 13, 2025 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area: assets Involved with assets (images, sounds, ...) improvement Enhancement of an existing component lang: python Done in Python code
Projects
openage converter
Status: 🏗 In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@heinezen