Fix Syntax Removal

[APickledWalrus]

Problem

Unregistering syntax via SyntaxRegistry#unregister will often fail silently. The issue was caused by the comparator used in SyntaxRegister not enforcing a consistent order for unique SyntaxInfos. Currently, elements are ordered first by Priority. Within the group of elements that share a Priority, it is ordered by registration-order (that is, which one was registered first). This ordering is random and not derived from any properties of the SyntaxInfos themselves. Thus, if I register some SyntaxInfo "A" and then register a whole bunch more, there is no guarantee that a call like register.contains(A) will be successful (it may not reach "A" due to the underlying data structure used).

Solution

The issue is resolved by enforcing a consistent ordering. That is, there will always be a consistent ordering for any collection of SyntaxInfos. This means it is no longer safe to simply change registration order to fix conflicts. Of course, this was never safe, and one should instead use Priorities - they are designed for this issue! This consistency accomplished by using hashcodes for ordering SyntaxInfos that share a priority.

Testing Completed

A new JUnit test was introduced in SyntaxRegistryTest.

Supporting Information

n/a

---

Completes: none
Related: none

[APickledWalrus]

On hold as this results in a lot of syntax conflicts that we can't reasonably resolve. Ideally, pull requests like #7892 should help with this.

[APickledWalrus]

Breaking changes:

• Syntax ordering is no longer based on registration order
• EffLoadWorld now requires world in the load effect. load %strings% was not ideal.