Skip to content

ExprArmorSlot With EquipmentSlots #7906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Absolutionism
Copy link
Contributor

Problem

The pattern for ExprArmorSlot was getting clunky and would become hard to follow for any other slots that would be added.

Solution

This PR revamps the pattern to allow EquipmentSlot to be used and multiple.
To reduce breaking changes, extra patterns were added to the types.equipment slots to reflect what was available in the prior pattern of ExprArmorSlot
Also adds support for the new saddle equipment slot.

Testing Completed

ExprArmorSlot.sk
Manual spawning of select entities to ensure the new saddle equipment slot would be visible on these entities for the restriction of getting saddle slots of entities that don't.

Supporting Information

N/A


Completes: none
Related: none

@Absolutionism Absolutionism requested a review from a team as a code owner May 31, 2025 04:18
@Absolutionism Absolutionism requested review from APickledWalrus and erenkarakal and removed request for a team May 31, 2025 04:18
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label May 31, 2025
@Absolutionism Absolutionism requested a review from sovdeeth May 31, 2025 06:06
@Absolutionism Absolutionism requested a review from sovdeeth May 31, 2025 06:28
@sovdeeth sovdeeth moved this to Needs Reviews in 2.12 Releases Jun 3, 2025
@sovdeeth sovdeeth added enhancement Feature request, an issue about something that could be improved, or a PR improving something. dependencies Pull requests that update a dependency file (Dependabot) labels Jun 3, 2025
@sovdeeth sovdeeth removed the dependencies Pull requests that update a dependency file (Dependabot) label Jun 3, 2025
Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks pretty good. i found a few things

Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

almost there!

Copy link
Member

@APickledWalrus APickledWalrus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good work

@github-project-automation github-project-automation bot moved this from In Review to Awaiting Merge in 2.12 Releases Jun 26, 2025
@APickledWalrus APickledWalrus merged commit f84ee7f into SkriptLang:dev/feature Jul 1, 2025
5 checks passed
@skriptlang-automation skriptlang-automation bot added the completed The issue has been fully resolved and the change will be in the next Skript update. label Jul 1, 2025
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done in 2.12 Releases Jul 1, 2025
@skriptlang-automation skriptlang-automation bot removed the needs reviews A PR that needs additional reviews label Jul 1, 2025
Burbulinis pushed a commit to Burbulinis/Skript that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
Status: Done - Released
Development

Successfully merging this pull request may close these issues.

3 participants