-
-
Notifications
You must be signed in to change notification settings - Fork 404
ExprArmorSlot With EquipmentSlots #7906
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExprArmorSlot With EquipmentSlots #7906
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good. i found a few things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
almost there!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good work
Problem
The pattern for
ExprArmorSlot
was getting clunky and would become hard to follow for any other slots that would be added.Solution
This PR revamps the pattern to allow
EquipmentSlot
to be used and multiple.To reduce breaking changes, extra patterns were added to the
types.equipment slots
to reflect what was available in the prior pattern ofExprArmorSlot
Also adds support for the new
saddle
equipment slot.Testing Completed
ExprArmorSlot.sk
Manual spawning of select entities to ensure the new
saddle
equipment slot would be visible on these entities for the restriction of getting saddle slots of entities that don't.Supporting Information
N/A
Completes: none
Related: none