Skip to content

EffSendBlockChange as Original #7949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

Absolutionism
Copy link
Contributor

Problem

Users would have to manually loop all blocks to be able to update the block for the players as the correct block/on the server.

Solution

Adds a new pattern in EffSendBlockChange allowing users to easily revert the blocks for the players, reducing the number of times execute and getArray would needed to be called when doing it manually.

Testing Completed

javaw_ysh8clmES5.mp4

Supporting Information

N/A


Completes: #1428
Related: none

@Absolutionism Absolutionism requested a review from a team as a code owner June 14, 2025 23:55
@Absolutionism Absolutionism requested review from cheeezburga and erenkarakal and removed request for a team June 14, 2025 23:55
@skriptlang-automation skriptlang-automation bot added the needs reviews A PR that needs additional reviews label Jun 14, 2025
@Absolutionism Absolutionism added the enhancement Feature request, an issue about something that could be improved, or a PR improving something. label Jun 15, 2025
@Absolutionism Absolutionism requested a review from sovdeeth June 15, 2025 12:13
Copy link
Member

@cheeezburga cheeezburga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff

@skriptlang-automation skriptlang-automation bot added feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. and removed needs reviews A PR that needs additional reviews labels Jun 25, 2025
@Absolutionism Absolutionism moved this to Awaiting Merge in 2.12 Releases Jul 1, 2025
@APickledWalrus APickledWalrus merged commit 187a055 into SkriptLang:dev/feature Jul 1, 2025
5 of 6 checks passed
@github-project-automation github-project-automation bot moved this from Awaiting Merge to Done in 2.12 Releases Jul 1, 2025
@skriptlang-automation skriptlang-automation bot added completed The issue has been fully resolved and the change will be in the next Skript update. and removed feature-ready A PR/issue that has been approved, tested and can be merged/closed in the next feature version. labels Jul 1, 2025
@APickledWalrus APickledWalrus linked an issue Jul 1, 2025 that may be closed by this pull request
Burbulinis pushed a commit to Burbulinis/Skript that referenced this pull request Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
completed The issue has been fully resolved and the change will be in the next Skript update. enhancement Feature request, an issue about something that could be improved, or a PR improving something.
Projects
Status: Done - Released
Development

Successfully merging this pull request may close these issues.

Block change update
4 participants