-
-
Notifications
You must be signed in to change notification settings - Fork 400
Push X towards Y #7950
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
APickledWalrus
merged 5 commits into
SkriptLang:dev/feature
from
sovdeeth:feature/eff-pull
Jul 1, 2025
Merged
Push X towards Y #7950
APickledWalrus
merged 5 commits into
SkriptLang:dev/feature
from
sovdeeth:feature/eff-pull
Jul 1, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Burbulinis
approved these changes
Jun 15, 2025
Absolutionism
approved these changes
Jun 15, 2025
APickledWalrus
requested changes
Jul 1, 2025
APickledWalrus
approved these changes
Jul 1, 2025
Burbulinis
pushed a commit
to Burbulinis/Skript
that referenced
this pull request
Jul 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
completed
The issue has been fully resolved and the change will be in the next Skript update.
enhancement
Feature request, an issue about something that could be improved, or a PR improving something.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
It's quite common for users to want to push one entity towards another, or towards a specific location. This isn't very hard, it's
push {_X} along (vector from {_x} to {_y})
, but it's not immediately obvious. The main reason is that the pattern ispush %entities% [along] %direction%
and it's not explained that a vector is also a direction.This also has another weakness: pushing multiple entities towards the same point. This requires a loop over the entities to calculate the vector for each one.
Solution
I've added syntax to make it more intuitive and efficient to do this:
push %entities% (away from|towards) %location%
. Internally, it acts the same aspush {_X} along (vector from {_x} to {_y})
, it's just simpler for the user and more accessible for those unfamiliar with directions/vector interplay.I've made two possibly controversial choices that I'd like opinions on:
Testing Completed
Added EffPush.sk
Supporting Information
I am counting this as completing #1671, as though it isn't a direction, it is fulfilling the requested behavior.
I didn't want to make this a direction because I feel directions are already a bit bloated and hard to understand, and that it wouldn't really reduce the confusion around how to do this task.
Completes: #1671
Related: none